search

CesiumGS / cesium

An open-source JavaScript library for world-class 3D globes and maps :earth_americas:
https://cesium.com/cesiumjs/
Apache License 2.0
13.01k stars 3.51k forks source link

NYC 3D Tiles demo doesn't work in 2D or CV #5955

Open mramato opened 7 years ago

mramato commented 7 years ago

http://localhost:8080/Apps/Sandcastle/index.html?src=3D%20Tiles%20Feature%20Picking.html&label=All

In 2D, buildings are way off. In CV they are off and/or crooked depending on if you visited the tile in 3D mode first.

2D image

CV

image

mramato commented 7 years ago

CC @lilleyse @pjcozzi

pjcozzi commented 6 years ago

Also, switch back to 3D and only a subset of the buildings stream in. Perhaps there is an issue with what mode the scene is in when a tile is loaded?

image

mramato commented 6 years ago

Do we think this and #6056 have the same root cause?

pjcozzi commented 6 years ago

Yes.

via @Vineg in #6056

We have a 3dTiles model which gets corrupted after switching to 2d mode and then back to 3d. Some DrawCommands seem to have wrong BoundingSphere center and not being rendered. Can you take a look at https://github.com/AnalyticalGraphicsInc/cesium/blame/b0939bf96697ec8c51cc32b8b96c5ed79b94a71a/Source/Scene/Model.js#L3798 It seems that when we switch back to 3d, model._rtcCenter not gets switched back to _rtcCenter3D

OmarShehata commented 4 years ago

Came up again on the forum:

In addition - i found that changing the view corrupts my data. this means, when I changed to 2d view and after that back to 3d view nothing will be displayed - "the data are lost"

kteneyck commented 2 years ago

Any update on these issues when switching to 2D with 3D Tiles loaded into Cesium? The only way we're going to be able to support 2D is to unload and reload any tilesets we have when switching views.

lilleyse commented 2 years ago

@kteneyck we're actively working on this and other 2D bugs: https://github.com/CesiumGS/cesium/issues/9934

lilleyse commented 2 years ago

@j9liu can this be closed now that https://github.com/CesiumGS/cesium/pull/10384 is merged?

j9liu commented 2 years ago

yes, closing now!

mramato commented 2 years ago

I was super excited about this but when I tried main it looks like 2D is still broken?

This is pretty obvious in Manhattan, but especially obvious around Central Park:

Screenshot_20220531_110746

j9liu commented 2 years ago

@mramato was this with enableModelExperimental: true added to the Cesium3DTileset constructor? The PR was implemented for ModelExperimental and it isn't used by default (yet!)

mramato commented 2 years ago

@j9liu No, it wasn't. But if that's the case then I'm not sure why we would close this until everything "just works". I would consider this issue as part of the final testing that should happen when ModelExperimental goes away and just becomes Model.