search

CesiumGS / cesium

An open-source JavaScript library for world-class 3D globes and maps :earth_americas:
https://cesium.com/cesiumjs/
Apache License 2.0
12.79k stars 3.46k forks source link

Terrain snow shading #6070

Open pjcozzi opened 6 years ago

pjcozzi commented 6 years ago

@VElysianP @akhabbaz @HuYuxin great job with your snow rendering project in CIS 565!

Just like the BabylonJS teams, would you like to contribute it back to Cesium? It could just be the snow applied to the terrain, not the snow fall since I do not know if the snow fall will be fast enough for most Cesium users.

Please open a pull request and someone on the team can walk you through the process and even do some of the work to get it into production shape. For more on contributing to Cesium, see Opening a Pull Request. Thanks!

https://github.com/HuYuxin/CIS565FinalProjectCesiumSnow/blob/master/CIS565FinalProjectREADME.md

HuYuxin commented 6 years ago

Hi Patrick, Yes we'd love to contribute to Cesium! We will do some code clean up and then open the pull request.

For the live webGL demo on github project page, may we ask if there is special build instructions we need to follow? We have pushed one on gh-pages branch. The live demo could not show up due the error reported in this issue post. I downloaded the project on gh-pages branch and build locally, the page could load up successfully. I think we are not build and push it for live demo correctly. If you could provide us with help on how to do the live demo page for our project, we would be really appreciated. Thank you!

pjcozzi commented 6 years ago

@HuYuxin sounds great. The live demo should work as long as you build the demo before pushing to gh-pages. @likangning93 can help.

akhabbaz commented 6 years ago

Thank you Patrick and Yuxin and Yao hi, Would be happy to work on this. I would be happy to open a pull request if no one has done that yet.

All the best, Anton

On Tue, Dec 26, 2017 at 5:45 AM Patrick Cozzi notifications@github.com wrote:

@HuYuxin https://github.com/huyuxin sounds great. The live demo should work as long as you build the demo before pushing to gh-pages. @likangning93 https://github.com/likangning93 can help.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/AnalyticalGraphicsInc/cesium/issues/6070#issuecomment-353954037, or mute the thread https://github.com/notifications/unsubscribe-auth/AK9nRbSOlWsI13pbdaGYKm5UNkmft36zks5tEM5lgaJpZM4RKeq- .

pjcozzi commented 6 years ago

Rock on @akhabbaz, I haven't seen a pull request yet.

HuYuxin commented 6 years ago

Hi Patrick, I followed the Test Guide and ran some of the tests, and I noticed there were some error reported on files that we did not modified, such as Specs/Renderer/ComputeCommandSpec.js, Specs/Scene/ViewportQuadSpec.js, Specs/Scene/PointPrimitiveCollectionSpec.js, etc. Could these errors caused by our changes? May I ask how we are supposed to fix these errors?

Thank you

pjcozzi commented 6 years ago

@HuYuxin if there are no new test failures, then do not worry about the existing test failures - just check that they were already there in Cesium's master branch.

If you have the time, it would also be nice to see if those existing test failures on a particular operating system, browser, GPU, etc. are already known by looking through the issues labeled 'test failure' and submitting a new issue if needed.

HuYuxin commented 6 years ago

Hi Patrick, I have opened a pull request on behalf of our group. Because our original project repository was not exactly a forked repository from cesium master branch, so I added our changes in another forked repository, tested and used it to open the pull request, I hope that is OK.

Thank you

pjcozzi commented 6 years ago

Very cool, thanks @HuYuxin! Stay tuned for some feedback in #6082. It will be cool to have this as part of Cesium, congrats!

hpinkos commented 6 years ago

Parked in this branch: https://github.com/AnalyticalGraphicsInc/cesium/tree/terrain-snow-shading