search

CesiumGS / cesium

An open-source JavaScript library for world-class 3D globes and maps :earth_americas:
https://cesium.com/cesiumjs/
Apache License 2.0
13k stars 3.5k forks source link

Remove deprecation warning for fetchImage in 1.57 #7630

Closed OmarShehata closed 5 years ago

OmarShehata commented 5 years ago

The createImageBitmap PR #7579 changed the parameters for Resource.fetchImage and added a deprecation warning:

https://github.com/AnalyticalGraphicsInc/cesium/blob/master/Source/Core/Resource.js#L900

Which should be removed in 1.57.

Can we add the deprecation label? @hpinkos

It also looks like Resource.addQueryParameters deprecation warning was supposed to be removed in 1.45:

https://github.com/AnalyticalGraphicsInc/cesium/blob/master/Source/Core/Resource.js#L612

lilleyse commented 5 years ago

I changed the title and description to 1.57 since the PR that deprecated the behavior was merged this month and needs at least one month of being deprecated.

Though I opened https://github.com/AnalyticalGraphicsInc/cesium/pull/7695 to remove addQueryParameters and addTemplateValues.

tfili commented 5 years ago

@OmarShehata Can you remove the deprecation warning for the next release?

tfili commented 5 years ago

Fixed in #7799