Closed lilleyse closed 3 years ago
@lilleyse what would be the best way to test this? and is there a reason why there aren't any unit tests in this PR?
@ptrgags thanks for the reminder, I meant to write a test but forgot
@ptrgags ready
Looks good, thanks @lilleyse!
This PR deletes the uri property of the
binary_glTF
buffer, which is meant to be ignored because the binary chunk should be used instead. Without this fix the glTF 1.0 to 2.0 update step may produce an invalid buffer.From the KHR_binary_glTF glTF 1.0 extension:
Here's what a glTF like this looks like. A fake
uri
is used becausebuffer.schema.json
requires thaturi
exists. Theuri
would be deleted after this change.