search

CesiumGS / gltf-pipeline

Content pipeline tools for optimizing glTF assets. :globe_with_meridians:
Apache License 2.0
1.87k stars 241 forks source link

Use JavaScript Array.fill in place of Cesium.arrayFill #615

Closed jjhembd closed 2 years ago

jjhembd commented 2 years ago

Several library functions and tests are generating pre-filled arrays using the polyfill method Cesium.arrayFill. This polyfill is no longer needed, since the JavaScript method Array.fill is implemented on all supported platforms. See https://github.com/CesiumGS/cesium/pull/10488.

This PR removes the calls to the polyfill, and replaces them with calls to Array.fill.

lilleyse commented 2 years ago

Thanks @jjhembd. I removed the CHANGES.md entry since this change is completely internal and doesn't impact the public API. Otherwise looks great.

lilleyse commented 2 years ago

Oh wait, looks like there's an eslint error. Could you fix that?

jjhembd commented 2 years ago

Thanks @lilleyse! Sorry I missed the eslint error. It's fixed now.