search

CesiumGS / gltf-pipeline

Content pipeline tools for optimizing glTF assets. :globe_with_meridians:
Apache License 2.0
1.87k stars 241 forks source link

Validate accessor min/max values #620

Closed javagl closed 1 year ago

javagl commented 1 year ago

Details discussed in https://github.com/CesiumGS/gltf-pipeline/pull/619

lilleyse commented 1 year ago

One side effect of putting this in updateVersion is it will slow down glTF 1.0 to 2.0 conversion in CesiumJS.

But that's probably not a big concern now that glTF 1.0 assets are relatively rare.

EDIT: I see you already mentioned this in #619

I can imagine that calling this function might be costly for larger models (and maybe it should be possible to enable/disable this step with a command line parameter or so...), and I'm not 100% sure whether that's the right place of calling it and so. But maybe it's worth considering this, just for the validity sake...