Replace materialsCommon with unlit

CesiumGS / obj2gltf

Convert OBJ assets to glTF

Apache License 2.0

1.71k stars 307 forks source link

Replace materialsCommon with unlit #152

Closed OmarShehata closed 5 years ago

OmarShehata commented 6 years ago

This is to resolve https://github.com/AnalyticalGraphicsInc/obj2gltf/issues/130.

Feedback is welcome!

lilleyse commented 5 years ago

Remove the Materials Common column from the "Mapping of mtl slots to shading models" table in the README.
Add an entry to CHANGES.md listed as a breaking change under a new 3.0.0 section.
If specularGlossiness and unlit are used together it should throw a DeveloperError.

lilleyse commented 5 years ago

Thanks @OmarShehata and sorry the long delay here. Just a couple small things. Otherwise everything looks good.

OmarShehata commented 5 years ago

Should be all good now @lilleyse !

OmarShehata commented 5 years ago

Let me know if the README and CHANGES look good. I also made sure it errors if the user supplies more than one flag out of specGloss, metalRough or unlit. @lilleyse

lilleyse commented 5 years ago

Thanks @OmarShehata. All the changes look good.