Update triangulation algorithm (1.0)

CesiumGS / obj2gltf

Convert OBJ assets to glTF

Apache License 2.0

1.7k stars 305 forks source link

Update triangulation algorithm (1.0) #158

Closed lilleyse closed 5 years ago

lilleyse commented 5 years ago

Same as #157 but for the 1.0 branch.

@OmarShehata could you test? The changes should be basically the same as #157.

OmarShehata commented 5 years ago

Looks good! I was able to convert the obj model to a glTF 1.0 and view it with the model inspector. Looks same as in the correct version in https://github.com/AnalyticalGraphicsInc/obj2gltf/pull/157.

Tests are also all passing locally. Travis seems to be failing because it's running with an older version of Node that doesn't support the spread ... operator?

lilleyse commented 5 years ago

Thanks @OmarShehata.

Fixed the travis build in https://github.com/AnalyticalGraphicsInc/obj2gltf/pull/159.