search

CesiumGS / obj2gltf

Convert OBJ assets to glTF
Apache License 2.0
1.71k stars 307 forks source link

Duplicate materials with mismatching attributes #162

Closed lilleyse closed 5 years ago

lilleyse commented 5 years ago

Fixes https://github.com/AnalyticalGraphicsInc/obj2gltf/issues/160

Duplicates materials whose referring primitives don't have the same attribute types. E.g. if a textured material is referenced by a primitive with both positions and uvs and a primitive with just positions, the material will be duplicated such that the first copy is unchanged and the second copy has textures removed.

https://github.com/AnalyticalGraphicsInc/obj2gltf/pull/161 needs to be merged first in order for the tests to pass.

To do:

lilleyse commented 5 years ago

@likangning93 should be ready now.

likangning93 commented 5 years ago

:+1:

Just waiting on https://github.com/AnalyticalGraphicsInc/obj2gltf/pull/161 now

lilleyse commented 5 years ago

@likangning93 - ready now.

likangning93 commented 5 years ago

:+1: