CesiumGS / obj2gltf

Convert OBJ assets to glTF
Apache License 2.0
1.7k stars 305 forks source link

Separate resources no longer hit Node buffer size limit #185

Closed lilleyse closed 5 years ago

lilleyse commented 5 years ago

Checks if the combined bin section of the glTF would exceed the Node buffer size limit (~2GB). If it does don't combine the accessors together, instead save them as separate .bin files.

It should be pretty unlikely that a single accessor would ever exceed 2GB. The obj reader splits the data up after every 1000000 vertices to avoid exploding the vertex cache.

lilleyse commented 5 years ago

It should be pretty unlikely that a single accessor would ever exceed 2GB. The obj reader splits the data up after every 1000000 vertices to avoid exploding the vertex cache.

Actually this isn't true. However if we do run into more issues we can start splitting primitives when the vertex cache is reset.

likangning93 commented 5 years ago

:+1: