search

CesiumGS / obj2gltf

Convert OBJ assets to glTF
Apache License 2.0
1.68k stars 303 forks source link

What happened to `inputUpAxis` and `outputUpAxis` #209

Closed FreakTheMighty closed 4 years ago

FreakTheMighty commented 4 years ago

Pull request #68 added the ability to indicate the up axis of an OBJ and was merged into master in 2016. However, it appears to be gone. I'm having trouble tracking down the commit where it was removed. Was the removal intentional, if so I'm curious why it was taken out.

FreakTheMighty commented 4 years ago

Never mind, found it here https://github.com/AnalyticalGraphicsInc/obj2gltf/blob/master/CHANGES.md#200-2017-08-11

FreakTheMighty commented 4 years ago

I still don't see it in gltf-pipeline. Also, it sort of feels like the wrong place to put this option. According to the spec gltf Y axis should be up. Because the OBJ file format doesn't provide that information, the converter should allow users to specify it.

lilleyse commented 4 years ago

@FreakTheMighty yeah it looks like we never got to that stage in gltf-pipeline. I agree with your reasoning though and would be glad to bring that change back. Would you like to open a PR?

FreakTheMighty commented 4 years ago

@lilleyse sounds good. I did a very quick cherry pick and conflict resolution https://github.com/FreakTheMighty/obj2gltf/tree/feature/up-axis

I think the tests need to be fixed, but otherwise it seems to be working. I'll open a pull request once its been cleaned up.

lilleyse commented 4 years ago

@FreakTheMighty great, thanks!

lilleyse commented 4 years ago

Fixed in https://github.com/AnalyticalGraphicsInc/obj2gltf/pull/211