search

CesiumGS / obj2gltf

Convert OBJ assets to glTF
Apache License 2.0
1.71k stars 307 forks source link

Handle mtl and texture absolute paths #219

Closed lilleyse closed 4 years ago

lilleyse commented 4 years ago

Fixes https://github.com/AnalyticalGraphicsInc/obj2gltf/issues/213

I confirmed that the tests fail if path.resolve is changed back to path.join.

OmarShehata commented 4 years ago

This works well. My only comment here is I think we should consider setting --secure to be true by default. In general, we should always create tools that are secure by default.

I don't think that should be a big issue for users of this library, since I imagine OBJs with relative absolute paths aren't common, and getting the old behavior would just be a matter of setting --secure false.

lilleyse commented 4 years ago

I opened a separate issue for secure by default: https://github.com/AnalyticalGraphicsInc/obj2gltf/issues/220

Is this one ok to merge?

OmarShehata commented 4 years ago

Yup, this is good! Thanks for opening the issue.