search

CesiumGS / obj2gltf

Convert OBJ assets to glTF
Apache License 2.0
1.71k stars 307 forks source link

Windows line endings break #! parsing on Linux #25

Closed jsheard closed 8 years ago

jsheard commented 8 years ago

Although the git repo has unix-style line endings, the version of obj2gltf on npm has Windows line endings. When running the command line tool the extra \r confuses the Linux #! parser:

$ lsb_release -d
Description:    Ubuntu 16.04.1 LTS

$ npm install -g obj2gltf
[...]

$ obj2gltf
/usr/bin/env: ‘node\r’: No such file or directory

$ dos2unix ~/.local/node/lib/node_modules/obj2gltf/bin/obj2gltf.js
dos2unix: converting file /home/josh/.local/node/lib/node_modules/obj2gltf/bin/obj2gltf.js to Unix format ...

$ obj2gltf
Usage: ./bin/obj2gltf.js [INPUT] [OPTIONS]
[...]
lilleyse commented 8 years ago

Thanks for letting me know! A new version should published to npm soon.

lilleyse commented 8 years ago

The new version 0.1.6 is now published.