search

CesiumGS / obj2gltf

Convert OBJ assets to glTF
Apache License 2.0
1.67k stars 302 forks source link

New optional parameter `doubleSidedMaterial` to force materials to be rendered on both sides #294

Closed chetan-set closed 9 months ago

chetan-set commented 9 months ago

I have started a disussion here to discuss the merits of setting the doubleSided parameter of gltf materials to true in some cases. This pull request implements that change

lilleyse commented 9 months ago

@chetan-set this looks like a good change - could you sign the Cesium CLA so we can review/merge?

https://github.com/CesiumGS/cesium/blob/main/CONTRIBUTING.md#contributor-license-agreement-cla

chetan-set commented 9 months ago

Thank you @lilleyse. I have now signed the Cesium CLA.

lilleyse commented 9 months ago

Thanks @chetan-set, I had some additional changes that I wanted to push to your branch but in the process managed to auto-close the PR. Anyways, I opened https://github.com/CesiumGS/obj2gltf/pull/295 which includes both our commits.

chetan-set commented 9 months ago

Thank you @lilleyse