search

CesiumGS / obj2gltf

Convert OBJ assets to glTF
Apache License 2.0
1.71k stars 307 forks source link

Consider replacing period usage in command line parameters #53

Closed mramato closed 7 years ago

mramato commented 7 years ago

I noticed we have periods in our cmd arguments, for example --ao.enable. It's standard to use a hyphen to separate words, I've never seen periods used like this: --ao-enable. Hyphens are standard enough that yargs automatically duplicated this to aoEnable on the parsed object to make it easily indexable from JavaScript without having string literals everywhere.

lilleyse commented 7 years ago

This is meant for gltf-pipeline, right?

mramato commented 7 years ago

Whoops, yes, sorry.