search

CesiumGS / obj2gltf

Convert OBJ assets to glTF
Apache License 2.0
1.71k stars 307 forks source link

Node string limitations #59

Open lilleyse opened 7 years ago

lilleyse commented 7 years ago

Buffers larger than ~192MB cannot be base64 encoded due to a NodeJS limitation. https://github.com/nodejs/node/issues/4266

It would be good to get around this. In most cases however using the --separate flag is the way go.

patty-victor commented 7 years ago

Any changes on this?

lilleyse commented 7 years ago

No change right now - however both --separate and --binary are not affected by this problem. This only happens when embedding resources as data-uris.

roy7 commented 6 years ago

You might try this in node v8.10. It fixed a problem we were having with a max string size limitation.

likangning93 commented 5 years ago

Heads-up that we may also be able to reduce instances of the string limitation by binning buffers, iirc obj2gltf tries to generate a single output buffer, but there's tons of models out there where the geometry can be "binned" into multiple buffers based on something simple like material use or perhaps different vertex attributes.