Fix compatibility with a variety of non-WebGL browsers.

CesiumGS / webglreport

A web page that reports a browser's WebGL capabilities, including supported extensions and implementation specific capabilities, such as the maximum number of texture units.

https://webglreport.com

Apache License 2.0

391 stars 99 forks source link

Fix compatibility with a variety of non-WebGL browsers. #14

Closed emackey closed 10 years ago

emackey commented 10 years ago

template and report were being declared too late for non-WebGL browsers, and they would show no report.
Added a new section on "WebGL not enabled" which is a different error than "not supported."
Added a message if JavaScript itself is disabled.
Request IE=Edge so that IE11 without Chrome Frame reports correctly.
Viewport tweaks for mobile.

mramato commented 10 years ago

What does this report on iOS? Looking at it makes me think we will end up telling them WebGL is not enabled, when in reality it's not supported.

emackey commented 10 years ago

Yeah, I wasn't sure what to tell the iOS folks. If they do officially support WebGL one day, it may still be disabled on older devices. The software can't detect Apple's official policy, to figure out the politics of why WebGL is disabled.

We should test get.webgl.org on iOS and compare.

mramato commented 10 years ago

I guess the target audience are developers, correct? If so then "supported but disabled" is probably an accurate message to give them. It would confuse non-developers though, who may then spend time trying to figure out how to enable it.

emackey commented 10 years ago

Let's not bike-shed this too much, this pull contains critical fixes for non-WebGL browsers.

emackey commented 10 years ago

@pjcozzi said I could merge this.