search

CesiumGS / wetzel

Generate Markdown documentation from JSON Schema
Apache License 2.0
134 stars 54 forks source link

Add initial support for draft 7 #41

Closed mohd-akram closed 3 years ago

mohd-akram commented 3 years ago

This just allows wetzel to read draft 7 schemas instead of falling back to version 3. Draft 7 is not very different from 4 so it will work for most cases.

emackey commented 3 years ago

Will we eventually need a separate schema resolver for 7? I'm not well-versed on the differences myself, but someone I'm working with mentioned there would be breaking changes if we upgraded the glTF schemas to 7.

I don't think it looks clean to have draft 7 feed into the old schema 4 resolver, but on the other hand, I wouldn't want to copy/paste the whole file and rename it to 7 just to fix that. But if a schema 7 resolver could have some substantial difference from the 4 resolver, then maybe that's the right thing?

If there aren't substantial changes, maybe we call it the schema4to7resolver?

emackey commented 3 years ago

Fixed in #59.