CessnaSkyhawk / SkyhawkScienceSystem

Other
12 stars 18 forks source link

MM error with Hypergolics.cfg on restock-engine-125-pug #11

Closed Gordon-Dry closed 2 years ago

Gordon-Dry commented 2 years ago
[LOG 14:43:02.627] Applying update SkyhawkScienceSystem/Patches/Hypergolics/Hypergolics/@PART[*]:HAS[#SSS_HypergolicTank[True]]:AFTER[zzzSkyhawkScienceSystem] to ReStockPlus/Parts/Engine/125/restock-engine-pug.cfg/PART[restock-engine-125-pug]
[ERR 14:43:02.628] Error - Cannot parse variable search when replacing (%) key lfo_volume = #$RESOURCE[LiquidFuel]/maxAmount$
[ERR 14:43:02.628] Error - Cannot parse variable search when replacing (%) key ox_volume = #$RESOURCE[Oxidizer]/maxAmount$
[WRN 14:43:02.629] Cannot find key lfo_volume in PART
[ERR 14:43:02.629] Error - Cannot parse variable search when inserting new key amount = #$/lfo_volume$
[WRN 14:43:02.629] Cannot find key lfo_volume in PART
[ERR 14:43:02.629] Error - Cannot parse variable search when inserting new key maxAmount = #$/lfo_volume$
[WRN 14:43:02.629] Cannot find key ox_volume in PART
[ERR 14:43:02.629] Error - Cannot parse variable search when inserting new key amount = #$/ox_volume$
[WRN 14:43:02.629] Cannot find key ox_volume in PART
[ERR 14:43:02.629] Error - Cannot parse variable search when inserting new key maxAmount = #$/ox_volume$

The fuels are inside

            name = ModuleB9PartSwitch
            moduleID = RRLFBSwitch
            switcherDescription = RR Fuel
            switcherDescriptionPlural = RR Fuel Options
Gordon-Dry commented 2 years ago

Wait, those ModuleB9PartSwitch are no tanks, they're all

                    IDENTIFIER
                    {
                        name = ModuleEnginesFX
                    }

But those are moduleID = RRLFBSwitch which, means those are tank + engine.

Gordon-Dry commented 2 years ago

I'm working on a PR.

CessnaSkyhawk commented 2 years ago

Alright - thank you so much for the help. I'm loading up my instance now as well to take a look.

Gordon-Dry commented 2 years ago

There is a ridicilous error - and I needed a break. I don't get it, the upper half of TankSwitch.cfg works as intended, but the lower half does not. With the same syntax.

Gordon-Dry commented 2 years ago

This commit https://github.com/CessnaSkyhawk/SkyhawkScienceSystem/commit/57fb16693447d55e793fbf232db360a09dc004d0 brought the bug back. Please revert the revert.