search

CessnaSkyhawk / SkyhawkScienceSystem

Other
12 stars 18 forks source link

Some BDB Contracts are not able to be proposed #32

Closed Moe-Kitsune closed 2 years ago

Moe-Kitsune commented 2 years ago

The unmanned target vessel, Kerbolar study, weather study, and one giant leap contracts from BDB seem to still require stock techs and thus won't be able to be proposed unless you're keeping some stock techs around with different names.

Edit: seems like I forgot there were 2 recon contracts in BDB

Moe-Kitsune commented 2 years ago

So I looked through the contract fix patch and it seems like the first three contracts require any of the specified techs to unlock, and the patch is set up as if it was a contract that requires all of the techs to be unlocked. Couldn't find anything in the code for the Apollo contract so maybe that was left out on accident. I'll test out the fixes for the contracts and report back

Morphisor244 commented 2 years ago

You're right, the OSO, Nimbus and Gemini contracts patching weren't setup correctly, I submitted PR to fix this. I also added the reqs for the Apollo contract, my earlier patching for TETRIX avoided this because BDB hadn't (hasn't) finished placing Apollo parts for itself - but if SSS already does this, no reason to leave it out.

CessnaSkyhawk commented 2 years ago

Alright - thanks for the help. I just accepted the PR. I normally play science mode rather than career, so I'm not too familiar with the BDB contracts