search

CeuAzul / ADR

Aircraft Design Resources - aircraft conceptual design framework
https://ceuazul.github.io/ADR
MIT License
14 stars 2 forks source link

Add tests for Power class #202

Closed joaofoes closed 4 years ago

joaofoes commented 4 years ago

Fixes #143

rafaellehmkuhl commented 4 years ago

This seems also ready, right @joaofoes?

EDIT: just saw that there are other functions needing test, sorry.

joaofoes commented 4 years ago

Yeah exactly. One more thing, there's some funcitons that returns more than one self value (it isnt a functional function). For the test, i should test all the self parameters that the function creates or if i test just one of them is enough? In my thought it is necessary to test all of them but i would like a confirmation. @rafaellehmkuhl

rafaellehmkuhl commented 4 years ago

Yes, you need to test for all the relevant modifications the function introduces.

joaofoes commented 4 years ago

I've noticed that the error is related to coverage percentage. I don't quite know what that means, and in fact i've didn't changed anything on the code itself, just on the imports.

rafaellehmkuhl commented 4 years ago

Don't worry about the coverage check. It will fail sometimes when it thinks there are already tests for a function but it doesn't.

Travis is the one to watch for. It has to pass, always.