search

Cevantime / moijv_oss

0 stars 12 forks source link

Add Form to update User Profile #7

Open guillaumehanotel opened 3 years ago

guillaumehanotel commented 3 years ago

Hello @Cevantime

I added a form in the Profile page to update the user's information.

Thank you for giving me feedback.

Guillaume

Cevantime commented 3 years ago

Hi @guillaumehanotel, thank you so much for your contribution. It seems to work just fine. However, it looks like the ProfileFormType is very similar to the Regsitration Type. It might be great to merge the two formular type into a single one in order to avoid code repetition. What do you think ?

guillaumehanotel commented 3 years ago

Hello @Cevantime,

All fields of these two forms are not equivalent so I've merged the common fields of these forms in a new form (UserType) and use it in both forms to avoid code repetition.

Tell me if it's okay with you.