Fullstack-project review

[ShootingStar91]

Fullstack-project review

This is a review for your fullstack-project. You do not need to implement possible suggestions for improvement mentioned here to receive your credits.

User experience

• A clean, easy-to-use user interface
• Works quickly
• Input validations and error messages are implemented well
• The layout doesn't work well on a mobile screen. With very small adjustments, it could be made to work. For example the input modals go out of screen sides, or labels and other elements don't position nicely on a mobile-sized screen
• The login vanishes on page refresh, which is not nice for the user. You could save the token in localstorage, for example, to keep it even through page refreshes
• When editing an expense (or a profile), all the fields have to be refilled. It would be nicer if the existing values were as default values in the fields, so that if I want to only change the amount, I don't have to re-write all fields.
• Functionalities work well: Adding, editing, deleting stuff, registering and logging in. No bugs found during the testing

Code

Frontend

• Good, well-organized and readable React
• In frontend services, instead of having duplicate code for adding the token to each requests, you could use an axios interceptor to add it to all of them

Backend

• Well-organized code here as well
• Authentication done well with a middleware

Overall

The application looks clean and is simple to use. It includes several read, write, update and delete -functionalities. Everything seems to work well, no major issues were found. The code is clean and well-organized. Good job! :gem:

[CezarBudeci]

@ShootingStar91 Thank you for the review! When will the ECTS be available in studyinfo?

[ShootingStar91]

The credits are already put into SISU of Helsinki University, although they may take 1-2 days to update. Then, I dont know if they automatically go into studyinfo or if you need to do something more; I'm not familiar with this system.