search

CezaryDanielNowak / React-dotdotdot

Multiline text ellipsis for react. Demo:
https://nowak.click/react-dotdotdot/
MIT License
401 stars 54 forks source link

Take in clamp as an npm module? #43

Closed JoshuaKGoldberg closed 8 months ago

JoshuaKGoldberg commented 6 years ago

You have clamp.js in your source repo. It'd be helpful for users of bundle loaders such as Rollup and Webpack if you referenced an npm module instead. That way our bundle loaders can intelligently deduplicate packages such as clamp.

JoanClaret commented 5 years ago

+1

CezaryDanielNowak commented 5 years ago

Original josephschmitt/Clamp.js is unmantained for a long time (6 years already). It's also buggy. Version included to React-dotdotdot has lots modifications. I agree, that it would be better to host it as a Clamp.js fork but this way it's easier to maintain for me.

JoshuaKGoldberg commented 8 months ago

Closing out my old issues in repos that haven't had updates in a few years. Cheers!