search

Cgboal / SonarSearch

A rapid API for the Project Sonar dataset
MIT License
641 stars 96 forks source link

invalid IPv4 address #37

Closed neilunderwood closed 2 years ago

neilunderwood commented 2 years ago

Since updating to V2, I've been able to get one search run successfully. Everything since results in this:

[09:25:13] user@hostname:~$ crobat -r 8.8.8.8 2021/09/16 09:25:21 rpc error: code = Unknown desc = invalid IPv4 address

This happens no matter the IP address. I tried deleting the binary and reinstalling but same story.

ENV: WSL1 Debian instance running on Windows 10 19042.1165

Thanks for all your efforts.

Cgboal commented 2 years ago

Ah really? I changed the way it does IP range calculations yesterday because it was resulting in DoS. Was working over HTTP but I didn't check the gRPC one as it uses the same function. I'll look into this asap.

On Thu, Sep 16, 2021, 5:32 PM Neil Underwood @.***> wrote:

Since updating to V2, I've been able to get one search run successfully. Everything since results in this:

[09:25:13] @.***:~$ crobat -r 8.8.8.8 2021/09/16 09:25:21 rpc error: code = Unknown desc = invalid IPv4 address

This happens no matter the IP address. I tried deleting the binary and reinstalling but same story.

ENV: WSL1 Debian instance running on Windows 10 19042.1165

Thanks for all your efforts.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Cgboal/SonarSearch/issues/37, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABD4Q7B4PSXV2NKEBP5N6HTUCIL2DANCNFSM5EFE3JTA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Cgboal commented 2 years ago

This is now resolved

Cgboal commented 2 years ago

Stupid IPv4 parsing library decided that all IP's in a /32 are 256.256.256.256

https://github.com/Cgboal/SonarSearch/commit/6b047e51094f873fac3c77e8d0950adcde30bf47#diff-fe4ad137f5a000c082912ddfc13a903ff4e1bb4346fdced5d278de22158d495eR87

neilunderwood commented 2 years ago

Thank you so much for getting to this so quickly. Cheers!

Cgboal commented 2 years ago

No problem

On Fri, Sep 17, 2021, 2:47 PM Neil Underwood @.***> wrote:

Thank you so much for getting to this so quickly. Cheers!

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/Cgboal/SonarSearch/issues/37#issuecomment-921810424, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABD4Q7EEPG74RGIXJQ2BPTLUCNBFNANCNFSM5EFE3JTA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.