search

Cgboal / SonarSearch

A rapid API for the Project Sonar dataset
MIT License
641 stars 96 forks source link

Fixed reverse DNS range infinite loop in crobat client #42

Closed rwincey closed 2 years ago

rwincey commented 2 years ago

There is an infinite loop bug in the crobat client when performing a ranged-based reverse lookup. i.e. 127.0.0.1/32.

rwincey commented 2 years ago

This pull request also has a change to return the IP address along with the domain when performing a reverse lookup.

Cgboal commented 2 years ago

Cool looks good. Thank you.

rwincey commented 2 years ago

Awesome :) What's the usual timeframe before the new version will make it into the public server?

Cgboal commented 2 years ago

The client is updated now, just update your installation. For the server-side, i'll do it some time this week. Your change to add the IPv4 address to the response for reverse DNS will need some other changes made to support it though as it's not handled by the gRPC client as far as I can tell.

Cgboal commented 2 years ago

I'll add support for it in the client when I do the deployment.

rwincey commented 2 years ago

Ya, I have code for the gRPC client in my fork but I didn't add it because I didn't know how you'd prefer the output. Thanks for the help. :)