ChHarding
commented
10 months ago Noted! This is something I’ve tried to fix for a long time and never found a good solution. My assumption is that the coordinates that end up in to STL binary file get truncated from the float64 I use for processing into float32 which is what the STL spec requires. My only workaround for this is to use ASCII STL, so this would be my first suggestion to try with your case. The other, unsolvable issue are non-manifold vertices which get created when 2 cells touch diagonally (0 means undefined here, 1 is a valid elevation) like this:
01 10 10 01
I don’t think that’s a watertight issue but if it is, use clean_diags=True which will remove on of the two by setting it to undefined. The issue is also helped by using smooth_borders=True as that snips off one of the two triangles each cell gets and so lessens that chance for the diagonal case happening.
Unrelated: I’m a bit stuck getting your devcontainer stuff to start. I have the DevContainer extension for VSCode and haveDockerDesktop and WSL installed bit I just can’t figure out how to get the magic started :) I expect I need to do something with the 2 files in .devcontainer? How do I say: run the devcontainer.json file?
Cheers
Chris
On Dec 25, 2023, at 13:44, Thomas Pentenrieder @.**@.>> wrote:
I noticed that the STL created by Touchterrain isn't watertight, therefore giving me errors in most tools I import the model. The tools are usually able to fix the issue (e.g. Microsoft 3D Builder, Fusion 360) but having a correct STL returned would obviously be better.
This can also be confirmed programatically using trimesh:
import trimesh data = trimesh.load('/workspaces/map2stl/test/V2_2_11.18_48.01_tile_1_1.STL') print(data .is_watertight)
I started looking into why that is but wanted to track it here early in case this is a known issue.
— Reply to this email directly, view it on GitHubhttps://github.com/ChHarding/TouchTerrain_for_CAGEO/issues/86, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AEYDF5OPZK6TNT7MJMZJS4DYLHJQ3AVCNFSM6AAAAABBCSNDZ6VHI2DSMVQWIX3LMV43ASLTON2WKOZSGA2TKOBUGI2DANQ. You are receiving this because you are subscribed to this thread.Message ID: @.***>
Chris Harding Associate Professor Department of Geological & Atmospheric Sciences Touchterrain.geol.iastate.eduhttp://Touchterrain.geol.iastate.edu
ThomasPe
I noticed that the STL created by Touchterrain isn't watertight, therefore giving me errors in most tools I import the model. The tools are usually able to fix the issue (e.g. Microsoft 3D Builder, Fusion 360) but having a correct STL returned would obviously be better.
This can also be confirmed programatically using trimesh:
I started looking into why that is but wanted to track it here early in case this is a known issue.