search

ChadCSong / ShineButton

This is a UI lib for Android. Effects like shining.
MIT License
4.22k stars 547 forks source link

Enabling Support for Custom Icons #37

Closed prscX closed 6 years ago

prscX commented 6 years ago

Hi @ChadCSong,

This PR is w.r.t react-native-shine-button: issue: 4. We have a requirement to support custom icons as well. Since drawables are within ReactNative context, it is hard to get drawable resource id.

In order to support this I have provided public access to PorterShapeImageView.setShape method.

Please find below the output I have received:

screen shot 2018-04-01 at 4 15 45 pm

Can you please merge this PR. Please let me know in case any discussion is required for the same.

@afsadilson

Thanks </ Pranav >

prscX commented 6 years ago

Thanks @ChadCSong for merging the PR.

Thanks </ Pranav >