search

Chadtech / elm-money

All the worlds currencies.
https://package.elm-lang.org/packages/Chadtech/elm-money/latest/
MIT License
13 stars 2 forks source link

Suggestions for Chinese currency #5

Closed asianfilm closed 3 years ago

asianfilm commented 5 years ago

For Chinese currency, I'd suggest using "元" as the native symbol. And other changes below.

""" cny : Currency cny = { symbol = "RMB" , name = "Chinese Renminbi" , namePlural = "Chinese renminbi" , symbolNative = "元" , decimalDigits = 0 , code = "RMB" } """

Chadtech commented 5 years ago

Thank you. I will look into this.

Chadtech commented 5 years ago

Hi @asianfilm

Would it make sense if I changed just the native symbol? Or would changing just the native symbol alone not make sense without the other changes as well?

I did some research, and I can see that Renminbi and Yuan are the same currency, and that Renminbi is mostly used within China and Yuan is mostly used outside of China. But still when I click around online, I see the currency referenced mostly as "Chinese Yuan". So I am currently leaning towards not changing it to "Chinese Renminbi".

What do you think? You probably know more about this than I do.

asianfilm commented 4 years ago

Sorry, ! missed your second reply. Yes, it's fine to just change the native symbol! Although, even if keeping "yuan", I'd suggest changing the code to "RMB".

Chadtech commented 3 years ago

I just published 4.1.0 with the new native symbol. Thanks again!