Wrapping Backstory in a Value Object

[ChaelCodes]

fixes #

Description of Changes

Wrapping the config in a custom object (THANKS COREY HAINES) so it's easier to pull information about headings and values, and the validations are easier to write.

Screenshots

Problem Solved

More consistent access to Playbook config values.

PR Checklist

• [ ] Unit test coverage?
• [ ] Code Climate Passes? (Reach out to @ChaelCodes if checks need dismissing)
• [ ] Example Seed file if new data table introduced?

[ChaelCodes]

That's true.

On Sun, Mar 21, 2021, 19:59 Corey Haines @.***> wrote:

@.**** commented on this pull request.

In app/views/hunter_backstories/_hunter_backstory.html.erb https://github.com/ChaelCodes/HuntersKeepers/pull/222#discussion_r598329571 :

@@ -1,8 +1,8 @@ <% if hunter_backstory %>

• <%= playbook.backstory&.dig(:name) %>

• <%= link_to hunter_backstory.backstory&.name, hunter_backstory %>

If backstory is nil (which apparently is possible, since we are using &), then won't this line become

<%= link_to nil, hunter_backstory %>

So there won't be any text for the link, and nothing to click on?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ChaelCodes/HuntersKeepers/pull/222#pullrequestreview-617055892, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB57RDRQ4CZXBPDVS23CFGDTEZFZ3ANCNFSM4XHWGBDA .