search

ChaelCodes / HuntersKeepers

An app to make managing games of Monster of the Week easier.
MIT License
40 stars 26 forks source link

Add Protective Gear to the Chosen #263

Open ChaelCodes opened 3 years ago

ChaelCodes commented 3 years ago

Describe the Feature

The Chosen has access to protective gear, and this is not reflected in the seedfile, because they typically have custom weapons. This issue is just to create the protective gear.

Additional context

You can have protective gear worth 1-armour, if you want.

Quote from the book.

Describe the Technical Implementation of the Solution

Solution Add one piece of Gear to the chosen seed file.

Attributes Value
armor 1
description Protective Gear
harm 0
name Protective Gear
playbook_id

References

jonsugar commented 3 years ago

@ChaelCodes As requested, commenting for clarifications.

So, are you literally asking for just the seed? ... I have found 20191215140939_create_gears.rb and 20191215141222_create_hunters_gear.rb so I think I just need to add it around line 90 on chosen.seeds.rb?

If my understanding is correct what was confusing me was that it seems too simple. I'm not used to something this atomic. For example, I would have expected a feature so, add the migrations, add the seed, and, add something to the UI.

I'm not saying that the issues should be changed because these small ones actually make sense for newbies. Maybe my preconceptions of what I would have expected from a Laravel project are trolling me 🤷🏻

ChaelCodes commented 3 years ago

Yes! It actually is this simple. Asking a newbie to build an entire feature according to the standards of a codebase is a bit much in my opinion. There are a few issues in the list that are meaty like that, but they're not labeled "Good First Issue", at least, I hope they aren't!

Meaty issues like that are common in Rails projects as well, but in my experience, attempting to chop it up finer really helps in terms of delivery! Code Reviews of large features take a lot longer too.