search

ChaelCodes / MeetAnotherDay

An app to help you find and meet up with your friends at conferences.
MIT License
35 stars 20 forks source link

push footer down #120

Closed henrikac closed 10 months ago

henrikac commented 2 years ago

Description of Feature or Issue

closes # none

This PR attempts to push the footer to the bottom of the screen where there is very little content, e.g. login page.

Checklist

User-Facing Changes

conf-footer

ChaelCodes commented 2 years ago

I worry about the exact pixel count in CSS. While this looks great on desktop, for many mobile views, it works less perfectly.

Device New
iPhone SE iPhone SE - too far up
Pixel 5 Pixel 5 - weird spacing below footer
iPad Air iPad Air - too low
Galaxy Fold Galaxy Fold - didn't move footer?
Nest Hub Nest Hub - GORGEOUS LOOKS PERFECT
ChaelCodes commented 2 years ago

Hi! There are issues on the /about page now. 😢 We'll get it eventually. It looked lovely on the /events page though.