ChaelCodes / MeetAnotherDay

An app to help you find and meet up with your friends at conferences.
MIT License
35 stars 20 forks source link

Bug: Requesting Friend does not see Friendship #176

Closed ChaelCodes closed 5 months ago

ChaelCodes commented 7 months ago

Description

We should list friendship requests that the requestor has made on the friendship index page and the profile page.

If you (buddy) request another profile to become your friend, you should see the Friendship (in a status of "requested") on the friendship index page. Also, when you visit that profile, you should see that you have sent them a friend request.

Relevant Code

Only gets accepted Friendships - https://github.com/ChaelCodes/HallwayTracks/blob/7d69b5ddc7c0ce9641945da721e62b68e0462932/app/controllers/friendships_controller.rb#L10-L17

Only displays requests to you and active friendships - https://github.com/ChaelCodes/HallwayTracks/blob/7d69b5ddc7c0ce9641945da721e62b68e0462932/app/views/friendships/index.html.erb#L4-L15 Do we need a third table? Outgoing requests? Or a way to indicate direction of the friend request? Also, we should probably make this query in the controller and store it in a variable instead of the view.

Maybe outgoing friend requests should belong in the friendship table instead? We can use the status to indicate if it's requested or accepted. This would also be good, because if the request is declined or ignored, it'll be less obvious.

No logic for friend requests for button on profile - https://github.com/ChaelCodes/HallwayTracks/blob/7d69b5ddc7c0ce9641945da721e62b68e0462932/app/helpers/friendships_helper.rb#L6-L13