ChaelCodes / MeetAnotherDay

An app to help you find and meet up with your friends at conferences.
MIT License
35 stars 20 forks source link

Friend Requests can be made to Friends/Myself Visibility Profiles #183

Closed ChaelCodes closed 9 months ago

ChaelCodes commented 9 months ago

Description of Feature or Issue

closes #169

Originally you could not make friend requests to profiles who used friends and myself visibility. These profiles would redirect, and the only page you can submit friend requests on is the profile page.

This change will make profiles visible to authenticated users - those who've confirmed their email and are logged in. Only the avatar, name, and handle will be visible on the profile. The bio and events are still restricted.

We don't want to give unauthorized users visibility, because: A - they can't befriend profiles B - this prevents robots from viewing profiles C - this closes a loophole where blocked profiles can just log out

This is a good balance between protecting the privacy of the profile, and making it possible to befriend those profiles.

Checklist

User-Facing Changes

A friends visibility profile as a non-friend. The "request friend" button is visible and a message "You must be friends to view this profile." is displayed.

A myself visibility profile. The "request friend" button is visible and a message "This profile is not visible to others at this time." is displayed.