search

ChaelCodes / MeetAnotherDay

An app to help you find and meet up with your friends at conferences.
MIT License
35 stars 20 forks source link

#68 Fix the Test Suite #70

Closed yagosansz closed 3 years ago

yagosansz commented 3 years ago

Hi @ChaelCodes,

I also had to change spec/requests/profiles_spec.rb:141, because updating the handle to be a FactoryBot sequence ended up breaking that line - the handle would always be "ChaelCodes".

This time I ran docker-compose run --rm web bundle exec rspec to be sure my changes didn't add any bugs =)

Looking forward for your review =)

Closes #68

ChaelCodes commented 3 years ago

Oh, would you run rubocop as well? I'm almost off work and then I should be able to fix the CI builds on forked repos.

ChaelCodes commented 3 years ago

Would you mind rebasing with the changes? I think I've fixed the CI tooling.

ChaelCodes commented 3 years ago

It worked!! Test suite is fixed!! 🎉

yagosansz commented 3 years ago

It worked!! Test suite is fixed!! 🎉

w00t!

Thanks, @ChaelCodes !!!

Sorry I couldn't fix it right after I submitted the MR - yesterday was my niece's birthday =D

It's been a good learning experience! I didn't even know what rubocop and rebase were.