ChaelCodes / MeetAnotherDay

An app to help you find and meet up with your friends at conferences.

MIT License

35 stars 20 forks source link

Tech Debt: unconfirmed UserFactory #97

Closed ChaelCodes closed 2 years ago

ChaelCodes commented 2 years ago

Description

In #82, we made the decision to update the unconfirmed trait of the UserFactory. This reduced the complexity of this PR and allowed us to ship unconfirmed users quicker, which has been instrumental in onboarding new contributors and PR review. However, we'd like to properly test the flows for unconfirmed users who have access to the repository.

Changes

Create an overdue_unconfirmed trait with the current code of the unconfirmed trait.
Update the existing tests with overdue_unconfirmed.
Write new tests that prove an unconfirmed user can create a profile, attend events, and view profiles.

zedbydade commented 2 years ago

I will go work on this, if there is no problem.