search

Chaffelson / nipyapi

A convenient Python wrapper for Apache NiFi
Other
246 stars 76 forks source link

Fix force pg delete #181

Closed rsaggino closed 4 years ago

rsaggino commented 4 years ago

Fixing #167,#180

Check for connection to remove only in the parent PG
Keep track of which controllers have been removed to avoid removing them twice (creating a set would have been an alternative)
Remove only controllers inside the process group

Tested on NiFi 1.9 with Python 3.6

coveralls commented 4 years ago

Coverage Status

Coverage decreased (-0.3%) to 66.667% when pulling 11822c1170e7f4d7f7d89fc6feea55f074495fc5 on rsaggino:fix-force-pg-delete into b5297c2d825ba47be729e7906292f44ae9f9f642 on Chaffelson:master.

Chaffelson commented 4 years ago

will review, just travelling at the moment

Chaffelson commented 4 years ago

Am working on adding tests for your fixes today