search

Chaffelson / nipyapi

A convenient Python wrapper for Apache NiFi
Other
244 stars 76 forks source link

Allow deploy_template to use floats for positions #191

Closed bgeisberger closed 4 years ago

bgeisberger commented 4 years ago

NiFi API allows to use floats for positions. Type checkers are complaining about deploy_template if floats are used for locations. It still works, but the function should represent what the API is actually capable of.

coveralls commented 4 years ago

Coverage Status

Coverage increased (+0.4%) to 67.09% when pulling a7b1e7b9deba437f58df507d9446ee21319bd9ec on bgeisberger:master into c115237396a1dfa15cf1def783b321345a2fc633 on Chaffelson:master.

Chaffelson commented 4 years ago

Apologies for the delay here - I am on isolation childcare, I should have more time for review and merging from next month

Chaffelson commented 4 years ago

Rebased onto Current master and all tests passed, thanks for your contribution!