search

Chaffelson / nipyapi

A convenient Python wrapper for Apache NiFi
Other
245 stars 76 forks source link

fixed funnel position #224

Closed Geocali closed 3 years ago

Geocali commented 3 years ago

At creation of the funnel, the position was specified outside of the component and was not taken into account, so the position was always (0, 0).

This pull request fixes this, adds a test, and some explanations to start contributing to the library.

coveralls commented 3 years ago

Coverage Status

Coverage remained the same at 66.642% when pulling 956782fa627850d87e2bb558841d82570680f8ef on Geocali:fix-funnel-position into 164351ee2d92f8c4a75989310662bbad0f7bafc4 on Chaffelson:master.

Chaffelson commented 3 years ago

Thanks for this contribution!