search

Chaffelson / nipyapi

A convenient Python wrapper for Apache NiFi
Other
245 stars 76 forks source link

check-version should ignore snapshot #232

Closed ottobackwards closed 3 years ago

ottobackwards commented 3 years ago

A better fix would be to re-implement the version class ( which was written for python or other things ) so that it better supports the version format that nifi would support, and then offer options in the check_version function... or between the version classes or whatever such that you could say how you feel about snapshot vs release vs rc etc.

This current fix however will get you by :)

This change is Reviewable

coveralls commented 3 years ago

Coverage Status

Coverage increased (+0.1%) to 67.028% when pulling 763ec3516006f0ea642769b1317c8309add2d3e3 on ottobackwards:version-check-snapshots into d94a82192e94d2f1fb8e16e3582b639713a930f4 on Chaffelson:master.