search

Chaffelson / nipyapi

A convenient Python wrapper for Apache NiFi
Other
243 stars 76 forks source link

Adds child cascading to assign_context_to_process_group #267

Closed sdairs closed 2 years ago

sdairs commented 3 years ago

Adds an optional bool to assign_context_to_process_group that, when True, will cascade the assigned Parameter Context down to the direct children Process Groups of the named Process Group. Does not recur down to nested-children.

coveralls commented 3 years ago

Coverage Status

Coverage decreased (-0.07%) to 68.709% when pulling 4b3da746c2e21e92949289a6336d8eb2829e1234 on sdairs:cascae-context into 292aa1e8bc1c4d080d7b6acdf0cedfb4e77a1f03 on Chaffelson:main.

coveralls commented 3 years ago

Coverage Status

Coverage increased (+0.2%) to 68.995% when pulling 3941b04609ca2e538ee80ce1b51799cd5168d011 on sdairs:cascae-context into 292aa1e8bc1c4d080d7b6acdf0cedfb4e77a1f03 on Chaffelson:main.

ottobackwards commented 3 years ago

Ok, so I was mistaking on 1. wrt actually getting to all the children, sorry. I still think changing the call might be right ( looking for @Chaffelson input though ) Sorry.

Thanks for the contribution as well!

sdairs commented 3 years ago

Originally I went with single depth as I hadn't thought through all of the consequences of recurring over all children yet - After discussion with @Chaffelson I changed this to recur down to all children, so it's doing that after the second commit.

wrt to point 2 - yep, welcome feedback on that - I had considered returning a list of all the child PGs affected, but that meant either 1. changing the return type so it always returns a list or 2. having more than one possible return type - neither sounded ideal. Open to suggestions