Chaffelson / nipyapi

A convenient Python wrapper for Apache NiFi
Other
243 stars 76 forks source link

NiFi 1.19 update #322

Closed Chaffelson closed 1 year ago

Chaffelson commented 1 year ago
ottobackwards commented 1 year ago

Are these breaking changes wrt the RegistryClient* changes?

ottobackwards commented 1 year ago

I know you want to match the nifi version, but maybe a README notice or Upgrading.md or something?

Chaffelson commented 1 year ago

versioning.py is backwards compatible except for the one minor behaviour change in the API when it comes to creating a new NiFi Registry client. The renamed calls are within the low level client and are effectively wrapped by versioning.py, so unless some user is directly calling those API calls people won't be affected, and if they are it is a very minor renaming of the method.

ottobackwards commented 1 year ago

OK

ottobackwards commented 1 year ago

LGTM +1 FWIW