search

Chaffelson / nipyapi

A convenient Python wrapper for Apache NiFi
Other
245 stars 76 forks source link

NiFi 1.23.2 update #330

Closed Hexoplon closed 11 months ago

Hexoplon commented 1 year ago

Passes default, security and regression tests

ottobackwards commented 1 year ago

I think the changes to the pylintrc should be their own PR and discussion, as you do not just move to a new template, but you add different configuration.

For something like that I would want a new PR, which in the description spoke to what was added and why.

This isn't to say I'm against these changes, but as a reviewer, this should be it's own issue mr

Hexoplon commented 1 year ago

I think the changes to the pylintrc should be their own PR and discussion, as you do not just move to a new template, but you add different configuration.

For something like that I would want a new PR, which in the description spoke to what was added and why.

This isn't to say I'm against these changes, but as a reviewer, this should be it's own issue mr

I see what you mean and agree! I'll remove that commit.

Chaffelson commented 1 year ago

Hi @Hexoplon thanks for taking the time to put this together!

Would you please mind signing your commits?

I will have time in the next few days to test and merge this.

Hexoplon commented 1 year ago

@Chaffelson The commits are now signed! Sorry for taking a while

Chaffelson commented 1 year ago

Did some testing on this today - generally looks good, I'm mostly having issues with Python and requirement versions.

Can you share what OS / Python versions you tested on? I'll try to match yours and then branch into the rest.

Hexoplon commented 1 year ago

@Chaffelson I'm not at my computer until next week, but pretty sure I used python 3.9.18 on Ubuntu, running in WSL2. Have used the packaged version with newest dependencies on RHEL8 running python 3.9.16 as well, but not ran through the tests there. If you need more info I'll get it next week

Chaffelson commented 1 year ago

No, that's very helpful already thank you - I'll switch from testing the oldest compatible to matching your test and then seeing if I can work back and remove some of the stuff that simply won't work anymore in Py2 and Centos7.

ottobackwards commented 1 year ago

like Centos7 and py2? removing them? ;)

Chaffelson commented 1 year ago

Apologies for the delay - I haven't forgotten about this but we're into conference season now and my day job is keeping me very busy. This is on my to-do list.

Chaffelson commented 11 months ago

Tested on Windows 10 with WSL2 running Python3.8 in Pycharm Pro. Works great. I had to make some modifications to get the tests to run, but they are not related to the PR.

virtualenv>=16.0.0,<20.22
tox>=2.9.1,<4.0

Virtualenv dropped Python2 support after 20.22 so we'll need to pin it until we do the same. The tests were written for Tox 3, and Pycharm is not happy with Tox4, so we'll stick with 3 for now.

I'll put these into a small PR to go into the next release.

dleditschke commented 7 months ago

@Chaffelson are there plans to release official support for NiFi / NiFi Registry >1.17.0?

Chaffelson commented 6 months ago

Hi @dleditschke yes I think we can test all the way up to include the latest 1.x line. I haven't done any work on the 2.x line as yet, as NiPy has been relatively stable and I have been busy with my day job. I shall book a day out of my projects to test and cut a release this month, would that be suitable?