Closed michaelarnauts closed 3 weeks ago
Another fix could be to modify the swagger_templates/model.mustache
file. It seems that this doesn't impact other usages.
This is another one that should be fixed in Apache NiFi, but we can patch locally. I try not to commit local fixes until I know the next version of NiFi won't perpetuate the issue, so as with your other PR let me know if you'd like me to handle it or if you would like the contributor credit as you found and fixed it.
I'm okay with trying to upstream the changes to NiFi itself, but I can't find the swagger definition in their repository. Can you point me to the right direction?
This is another one that should be fixed in Apache NiFi, but we can patch locally. I try not to commit local fixes until I know the next version of NiFi won't perpetuate the issue, so as with your other PR let me know if you'd like me to handle it or if you would like the contributor credit as you found and fixed it.
I'm okay with trying to upstream the changes to NiFi itself, but I can't find the swagger definition in their repository. Can you point me to the right direction?
Hmm, I've found some annotations here (https://github.com/apache/nifi/blob/main/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/ProcessGroupResource.java#L282), I assume the swagger file is generated from those annotations?
I'm not sure where the fix should occur however, since from the NiFi standpoint, it's not wrong to say they respond with a string.
This is another one that should be fixed in Apache NiFi, but we can patch locally. I try not to commit local fixes until I know the next version of NiFi won't perpetuate the issue, so as with your other PR let me know if you'd like me to handle it or if you would like the contributor credit as you found and fixed it.
I'm okay with trying to upstream the changes to NiFi itself, but I can't find the swagger definition in their repository. Can you point me to the right direction?
Hmm, I've found some annotations here (https://github.com/apache/nifi/blob/main/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/ProcessGroupResource.java#L282), I assume the swagger file is generated from those annotations?
I'm not sure where the fix should occur however, since from the NiFi standpoint, it's not wrong to say they respond with a string.
Generally we would discuss it in the NiFi community - either on the Developer mailing list or in the community Slack.
You may wish to join the Developer mailing list, and then send an email with the couple of fixes wanted here to generate the discussion on what would be best. Alternatively, if you'd like to join the Slack community and join the nifi-http-clients
channel we can have the conversation with the other maintainers there.
This PR fixes creation of ParameterContexts. There are a few issues with the current implementation:
null
. This prevented the reply from being parsed correctly.Also, I noticed the following issues when trying to fix this:generate_api_client.sh
uses a invalid domain to fetch swagger-codegen-cli, it's also using an old version.Theself.logger["package_logger"] = logging.getLogger("swagger_client")
line was incorrectly updated in the past PR. Running the codegen sets it tologging.getLogger("nifi")
as it was before the last change.I'll move these changes to a different PR.
Fixes #325