search

Chailotl / particular

Enhances Minecraft's ambience with hand-crafted visual effects like fireflies, falling leaves, and waterfall cascades
GNU Lesser General Public License v3.0
38 stars 21 forks source link

[FEATURE] Splash presence based on height configurability #7

Open meowinqq opened 6 months ago

meowinqq commented 6 months ago

I know this is a bit of a tall order, and my very limited experience with modmaking makes me uncertain of whether or not this is even feasible, though I think it'd be super cool to be able to configure whether or not splashes occur based on how high a player/entity/item is falling from (i.e. splashes can be configured to only occur if a player/entity/item is falling with a certain amount of momentum, gained from fall height). This config would also work to disable the splashing effect when a player/mob is simply swimming along the surface, which can look a little odd.

My apologies for the poor description here, I'm not great at putting thoughts into words..! This mod is absolutely fantastic, thank you for all of the work you've poured into this! :0)

meowinqq commented 6 months ago

Apologies, commented w/ closing option enabled -- meant to attach this recording of the "splashing when swimming" I was describing. splash

Chailotl commented 5 months ago

This is certainly doable, so I can look into this ^^ The current water splash calculations are a bit messy so I'd like to clean them up first so that they can be sensibly configured by the end user