search

ChainAgnostic / namespaces

Chain-Agnostic Namespaces host informative specs and profiles of CAIPs (Chain-Agnostic Improvement Proposals) per blockchain ecosystem
https://namespaces.chainAgnostic.org/
44 stars 57 forks source link

add CAIP-10 for Algorand #72

Closed k13n closed 12 months ago

k13n commented 1 year ago

Add CAIP-10 definition for Algorand

ehanoc commented 1 year ago

@bumblefudge @ligi Could we get :eyes: on this? Thanks

bumblefudge commented 1 year ago

Apologies, both ligi and I were on leave the last few weeks. Just looking at this now, I find the prose sections very clear and explanatory; my only concern is that the chainId segment is not optional in CAIP-10, and we do not have a wildcard (i.e. "equally valid on any chainID"), so I would recommend putting in language to default to mainnet as canonical expression unless it is significant to store the chainID for context (for instance, in transaction receipts or records about interactions with actors or smart contracts on a given chainID). My request changes should be enough, if you find them unobjectionable, but also feel free to rework/reword as you see fit and I'll review again.

k13n commented 12 months ago

Thank you, the suggested changes look good to me!