search

ChainAgnostic / namespaces

Chain-Agnostic Namespaces host informative specs and profiles of CAIPs (Chain-Agnostic Improvement Proposals) per blockchain ecosystem
https://namespaces.chainAgnostic.org/
53 stars 64 forks source link

Incorrect Example in Solana CAIP-19 #73

Closed Sneh1999 closed 1 year ago

Sneh1999 commented 1 year ago

Hello 👋

I believe one of the examples mentioned in Solana CAIP-19 is incorrect

Instead of 

# One Solana Mainnet NFT：Pesky Penguins #398
solana:5eykt4UsFv8P8NJdTREpY1vzqKqZKvdp/token:Fz6LxeUg5qjesYX3BdmtTwyyzBtMxk644XiTqU5W3w9w

the example should be 

# One Solana Mainnet NFT：Pesky Penguins #398
solana:5eykt4UsFv8P8NJdTREpY1vzqKqZKvdp/nft:Fz6LxeUg5qjesYX3BdmtTwyyzBtMxk644XiTqU5W3w9w
bumblefudge commented 1 year ago

you're right, if those addresses actually map to those examples! would you care to open the PR yourself to get the git-credit? if not i'll just patch it myself

Sneh1999 commented 1 year ago

Done! https://github.com/ChainAgnostic/namespaces/pull/80