Open bumblefudge opened 10 months ago
The Rationale section says P2SH address types map well enough to EVM accounts for the purposes of CAIP-10 interop, but the examples start with 1 and are thus P2PKH addresses.
https://bitbox.swiss/blog/what-are-bitcoin-address-types/
Also, the regexp doesn't constrain the first byte of the address with an enum, and probably should if only certain BTC address types are valid...
Speaking of which, what about taproot and segwit addresses?
The Rationale section says P2SH address types map well enough to EVM accounts for the purposes of CAIP-10 interop, but the examples start with 1 and are thus P2PKH addresses.
https://bitbox.swiss/blog/what-are-bitcoin-address-types/
Also, the regexp doesn't constrain the first byte of the address with an enum, and probably should if only certain BTC address types are valid...
Speaking of which, what about taproot and segwit addresses?