search

ChainAgnostic / varsig

The cryptographic signature multifomat
Other
9 stars 4 forks source link

Fix Ed25519 sig-bytes size #14

Closed conr2d closed 1 month ago

conr2d commented 2 months ago

Ed25519 signatures are 64 bytes.

cla-bot[bot] commented 2 months ago

We require contributors to sign our Contributor License Agreement, and we don't have you on file. In order for us to review and merge your code, either PR in your signature like so if you have no other disclosures to make or reach out to one more of the codeowners (@bumblefudge @expede @oed) to get yourself added manually.

oed commented 2 months ago

Hi @conr2d is varsig something you are planning to use? Unfortunately we've stopped working on this standard and currently don't have any plans to restart the work.

cc @bumblefudge maybe it's time to archive the repo?

conr2d commented 2 months ago

@oed Thank you for letting me know about the project's discontinuation.

I have a project that uses various DSA and it's crucial to keep the data size small. I think using Multikey would work for cryptographic public keys, but for digital signatures, I haven't found a stabilized specification.

With this project's discontinuation, will the 0x34 varsig entry be removed from multicodec? If it remains, it seems like it would be still suitable for my use case.

expede commented 1 month ago

@conr2d this project is not discontinued. @oed just meant that Ceramic is not using it.

expede commented 1 month ago

@bumblefudge please see the above comment (RE do not archive)

expede commented 1 month ago

@conr2d

Ed25519 signatures are 64 bytes.

Oops indeed! Thanks :)