search

ChainMovers / suibase

Sui development environment and cookbook.
https://suibase.io
Apache License 2.0
35 stars 6 forks source link

Post processing HTML python script #45

Closed andreidev1 closed 1 year ago

andreidev1 commented 1 year ago

partially fixes #35

mario4tier commented 1 year ago

Thanks. Worked well.

Some feedback (I imagine you were probably already considering some of these since this was a quick first iteration/partial commit!):

(1) Please sort in reverse order (the one with most contribution should be first)

(2) In comments on top, please add instruction to start a static browser on ~/suibase/docs/src/.vuepress/dist (something I will forget 6 months from now).

(3) Consider making "grep -ril contributors" tighter. e.g. mermaid.core-0f834940.js should not be in the list Adding a bit more regex helps: grep -ril "const.JSON.git.*contributors"

(4) "const e" vs "const t" Is there a way to make this work without caring if e or t (who knows... could be a different letter used in slightly different scenario!)